Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-96280: suppress deprecation warning in test_importlib #96281

Merged
merged 1 commit into from
Aug 26, 2022
Merged

gh-96280: suppress deprecation warning in test_importlib #96281

merged 1 commit into from
Aug 26, 2022

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Aug 25, 2022 •
edited
Loading

@iritkatriel iritkatriel added tests Tests in the Lib/test dir skip news stdlib Python modules in the Lib dir 3.12 bugs and security fixes labels Aug 25, 2022
warsaw
warsaw approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but see the comment in the ticket.

@iritkatriel
Copy link
Member Author

Let’s hold off merging and see if @brettcannon has a view.

@brettcannon
Copy link
Member

I'm fine with it as a quick fix, but it's effectively just postponing having to deal with it for 3.14 when the class disappears.

@iritkatriel
Copy link
Member Author

I’ll merge this and leave the issue open. I wanted to mark it as a 3.14 release blocker but we don’t have a 3.14 label yet.

@iritkatriel iritkatriel merged commit ccf94a6 into python:main Aug 26, 2022
@iritkatriel iritkatriel deleted the test_importlib branch September 29, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdboom mdboom mdboom approved these changes

@brettcannon brettcannon brettcannon approved these changes

@warsaw warsaw warsaw approved these changes

Assignees
No one assigned
Labels
3.12 bugs and security fixes skip news stdlib Python modules in the Lib dir tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warning in test_importlib
5 participants
@iritkatriel @brettcannon @mdboom @warsaw @bedevere-bot