Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-87092: use basicblock_last_instr consistently #96243

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Aug 24, 2022

The compiler sometimes uses b->b_instr[b->b_iused-1] and sometimes basicblock_last_instr(b) for the same thing. This PR replaces the former by the latter, to simplify the code and make it more consistent.

Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iritkatriel iritkatriel merged commit fba3b67 into python:main Aug 24, 2022
@iritkatriel iritkatriel deleted the basicblock_last_instr branch September 29, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants