-
-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-34819: Use a monotonic clock to compute timeouts in concurrent.futures #9599
Conversation
Thanks for doing this! This looks good on the principle. Note however that the I think the NEWS message deserves improving a bit, I will edit it if you don't mind. |
(given the above, did you check this PR solves the issue with your script, btw?) |
I'd be glad if you did, it probably does need some clarification.
I double-checked to make sure and it indeed fixes it. |
Thanks @orlnub123 for the PR, and @pitrou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
Thanks @orlnub123 for the PR, and @pitrou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
GH-9600 is a backport of this pull request to the 3.6 branch. |
…tures (pythonGH-9599) Use a monotonic clock to compute timeouts in :meth:`Executor.map` and :func:`as_completed`, in order to prevent timeouts from deviating when the system clock is adjusted. This may not be sufficient on all systems. On POSIX for example, the actual waiting (e.g. in ``sem_timedwait``) is specified to rely on the CLOCK_REALTIME clock. (cherry picked from commit a94ee12) Co-authored-by: orlnub123 <orlnub123@gmail.com>
…tures (pythonGH-9599) Use a monotonic clock to compute timeouts in :meth:`Executor.map` and :func:`as_completed`, in order to prevent timeouts from deviating when the system clock is adjusted. This may not be sufficient on all systems. On POSIX for example, the actual waiting (e.g. in ``sem_timedwait``) is specified to rely on the CLOCK_REALTIME clock. (cherry picked from commit a94ee12) Co-authored-by: orlnub123 <orlnub123@gmail.com>
GH-9601 is a backport of this pull request to the 3.7 branch. |
…tures (GH-9599) Use a monotonic clock to compute timeouts in :meth:`Executor.map` and :func:`as_completed`, in order to prevent timeouts from deviating when the system clock is adjusted. This may not be sufficient on all systems. On POSIX for example, the actual waiting (e.g. in ``sem_timedwait``) is specified to rely on the CLOCK_REALTIME clock. (cherry picked from commit a94ee12) Co-authored-by: orlnub123 <orlnub123@gmail.com>
…tures (GH-9599) Use a monotonic clock to compute timeouts in :meth:`Executor.map` and :func:`as_completed`, in order to prevent timeouts from deviating when the system clock is adjusted. This may not be sufficient on all systems. On POSIX for example, the actual waiting (e.g. in ``sem_timedwait``) is specified to rely on the CLOCK_REALTIME clock. (cherry picked from commit a94ee12) Co-authored-by: orlnub123 <orlnub123@gmail.com>
https://bugs.python.org/issue34819