Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34789: make xml.sax.make_parser accept iterables of all types #9576

Merged
merged 9 commits into from
Oct 26, 2018
Merged

bpo-34789: make xml.sax.make_parser accept iterables of all types #9576

merged 9 commits into from
Oct 26, 2018

Conversation

andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Sep 25, 2018 •
edited by bedevere-bot
Loading

@andresdelfino andresdelfino mentioned this pull request Sep 26, 2018
Merged
taleinat
taleinat reviewed Oct 26, 2018
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a great opportunity to change the default value for parser_list from [] to something immutable, e.g. an empty tuple. (Using mutable default values is a Bad Idea™!)

@andresdelfino andresdelfino force-pushed the bpo-34789-make_parser-master branch from b62ac13 to b4cf5bb Compare October 26, 2018 13:43
@andresdelfino
Copy link
Contributor Author

@taleinat yes, I think you are right. My last commit addresses this suggestion too.

taleinat
taleinat reviewed Oct 26, 2018
View reviewed changes
taleinat
taleinat approved these changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taleinat taleinat changed the title bpo-34789: make xml.sax.make_parser accept iterables bpo-34789: make xml.sax.make_parser accept any iterable type Oct 26, 2018
@taleinat taleinat changed the title bpo-34789: make xml.sax.make_parser accept any iterable type bpo-34789: make xml.sax.make_parser accept iterables of all types Oct 26, 2018
@miss-islington
Copy link
Contributor

@andresdelfino: Status check is done, and it's a failure ❌ .

1 similar comment
@miss-islington
Copy link
Contributor

@andresdelfino: Status check is done, and it's a failure ❌ .

@taleinat taleinat merged commit a6dc531 into python:master Oct 26, 2018
@andresdelfino andresdelfino deleted the bpo-34789-make_parser-master branch October 26, 2018 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@taleinat taleinat taleinat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andresdelfino @miss-islington @taleinat @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot