gh-91323: Revert "Allow overriding a future compliance check in asyncio.Task (GH-32197)"#95442
Merged
Conversation
…cio.Task (pythonGH-32197)" This reverts commit d4bb38f.
Contributor
Author
|
I marked this as "skip news" as the original change wasn't mentioned in the change log. |
ambv
changed the title
ambv
changed the title
1st1
approved these changes
Jul 29, 2022
Member
1st1
left a comment
1st1
left a comment
There was a problem hiding this comment.
Yeah, according to #91323 (comment) this change isn't really needed.
I don't think it's much useful for anything else and I think the bar for adding new APIs to Tasks/Future is very high. Let's drop it for now. cc @asvetlov
Contributor
|
Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-95652 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 4, 2022
… asyncio.Task (pythonGH-32197)" (pythonGH-95442) This reverts commit d4bb38f. (cherry picked from commit 0342c93) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv
added a commit
that referenced
this pull request
Aug 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit d4bb38f.