Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95369: add missing decref in error case of exception group's split #95370

Merged
merged 1 commit into from
Jul 28, 2022
Merged

gh-95369: add missing decref in error case of exception group's split #95370

merged 1 commit into from
Jul 28, 2022

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jul 28, 2022 •
edited by bedevere-bot
Loading

@iritkatriel iritkatriel added 3.11 only security fixes 3.12 bugs and security fixes skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jul 28, 2022
@kumaraditya303 kumaraditya303 added the needs backport to 3.11 only security fixes label Jul 28, 2022
@erlend-aasland
Copy link
Contributor

There's a ref leak in the PyList_Append below as well, right?

@iritkatriel
Copy link
Member Author

There's a ref leak in the PyList_Append below as well, right?

In line 1117? I don't think so - match has been decreffed by then.

@erlend-aasland
Copy link
Contributor

Yes, of course; I see it now when I re-read the code. LGTM!

@iritkatriel iritkatriel merged commit bceb197 into python:main Jul 28, 2022
@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2022
@iritkatriel @miss-islington
pythongh-95369: add missing decref in error case of exception group's…
8520969 
… split (pythonGH-95370)

(cherry picked from commit bceb197)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 28, 2022
@bedevere-bot
Copy link

GH-95372 is a backport of this pull request to the 3.11 branch.

@iritkatriel iritkatriel added the type-bug An unexpected behavior, bug, or error label Jul 28, 2022
@iritkatriel iritkatriel deleted the eg_decref branch July 28, 2022 11:00
miss-islington added a commit that referenced this pull request Jul 28, 2022
@miss-islington @iritkatriel
gh-95369: add missing decref in error case of exception group's split (…
6934726 
…GH-95370)

(cherry picked from commit bceb197)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
3.11 only security fixes 3.12 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iritkatriel @erlend-aasland @miss-islington @bedevere-bot @kumaraditya303