Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-74116: allow multiple drain waiters for asyncio.StreamWriter #94705

Merged
merged 3 commits into from
Aug 29, 2022
Merged

GH-74116: allow multiple drain waiters for asyncio.StreamWriter #94705

merged 3 commits into from
Aug 29, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jul 9, 2022 •
edited by bedevere-bot
Loading

@kumaraditya303 kumaraditya303 self-assigned this Jul 9, 2022
graingert
graingert reviewed Jul 16, 2022
View reviewed changes
Lib/asyncio/streams.py Outdated Show resolved Hide resolved
@kumaraditya303 kumaraditya303 force-pushed the multiple-drainers branch 2 times, most recently from efcfd1d to f6ede6e Compare August 1, 2022 13:54
@kumaraditya303 kumaraditya303 requested review from gvanrossum and removed request for ambv and vstinner August 28, 2022 13:42
gvanrossum
gvanrossum reviewed Aug 28, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, I have a nit or two.

Misc/NEWS.d/next/Library/2022-07-09-08-55-04.gh-issue-74116.0XwYC1.rst Outdated Show resolved Hide resolved
Lib/asyncio/streams.py Outdated Show resolved Hide resolved
Lib/asyncio/streams.py Show resolved Hide resolved
Lib/asyncio/streams.py Show resolved Hide resolved
gvanrossum
gvanrossum approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! I'll merge next.

@gvanrossum gvanrossum merged commit e5b2453 into python:main Aug 29, 2022
@miss-islington
Copy link
Contributor

Thanks @kumaraditya303 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 29, 2022
@kumaraditya303 @miss-islington
pythonGH-74116: Allow multiple drain waiters for asyncio.StreamWriter (…
6d896c0 
…pythonGH-94705)

(cherry picked from commit e5b2453)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot
Copy link

GH-96395 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 29, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 29, 2022
@kumaraditya303 @miss-islington
pythonGH-74116: Allow multiple drain waiters for asyncio.StreamWriter (…
30aa1eb 
…pythonGH-94705)

(cherry picked from commit e5b2453)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 29, 2022
@bedevere-bot
Copy link

GH-96396 is a backport of this pull request to the 3.10 branch.

@kumaraditya303 kumaraditya303 deleted the multiple-drainers branch August 30, 2022 06:56
pablogsal pushed a commit that referenced this pull request Aug 30, 2022
@miss-islington @kumaraditya303
GH-74116: Allow multiple drain waiters for asyncio.StreamWriter (GH-9…
2e9f29e 
…4705) (#96395)

(cherry picked from commit e5b2453)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Sep 8, 2022
@miss-islington @kumaraditya303
GH-74116: Allow multiple drain waiters for asyncio.StreamWriter (GH-9…
f60bbf0 
…4705)

(cherry picked from commit e5b2453)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@kumaraditya303 kumaraditya303 mentioned this pull request Sep 9, 2022
Closed
@kumaraditya303 kumaraditya303 mentioned this pull request Sep 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graingert graingert graingert left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

@kumaraditya303 kumaraditya303

Labels
topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kumaraditya303 @miss-islington @bedevere-bot @graingert @gvanrossum