-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
bpo-34011: Fixes missing venv files and other tests #9458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change in venv/__init__.py
seems OK to me. I thought the venv tests worked when I ran them with an installed Python (you might remember some discussion back in July on Zulip about trying to build a WiX installer for Python - that was to test this issue using an installed Python). Not sure what I missed there.
@vsajip If you put Python on PATH when you installed, then it would work. But if you don't select that option, it can't find |
And I don't follow Zulip, so you can't rely on me noticing any conversations on there at all (ah okay, I was actually involved in this one :) ) |
Ah, right, that could well explain it. |
This buildbot is failing when raising when creating https://buildbot.python.org/all/#/builders/40/builds/1135/steps/3/logs/stdio
I will prepare a PR fixing this |
More Windows buildbots are failing: https://buildbot.python.org/all/#/builders/32/builds/1706 |
Mostly related to test fixes for when Python is running outside of a regular build directory. The only product impact is for bpo-34011
https://bugs.python.org/issue34011