Skip to content

bpo-34011: Fixes missing venv files and other tests #9458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 20, 2018

Conversation

zooba
Copy link
Member

@zooba zooba commented Sep 20, 2018

Mostly related to test fixes for when Python is running outside of a regular build directory. The only product impact is for bpo-34011

https://bugs.python.org/issue34011

@zooba zooba added tests Tests in the Lib/test dir skip news labels Sep 20, 2018
@zooba zooba changed the title bpo-34011 Fixes missing venv files and other tests bpo-34011: Fixes missing venv files and other tests Sep 20, 2018
Copy link
Member

@vsajip vsajip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in venv/__init__.py seems OK to me. I thought the venv tests worked when I ran them with an installed Python (you might remember some discussion back in July on Zulip about trying to build a WiX installer for Python - that was to test this issue using an installed Python). Not sure what I missed there.

@zooba zooba requested a review from a team as a code owner September 20, 2018 18:32
@zooba
Copy link
Member Author

zooba commented Sep 20, 2018

@vsajip If you put Python on PATH when you installed, then it would work. But if you don't select that option, it can't find python38.dll automatically.

@zooba
Copy link
Member Author

zooba commented Sep 20, 2018

And I don't follow Zulip, so you can't rely on me noticing any conversations on there at all (ah okay, I was actually involved in this one :) )

@vsajip
Copy link
Member

vsajip commented Sep 20, 2018

@vsajip If you put Python on PATH when you installed, then it would work. But if you don't select that option, it can't find python38.dll automatically.

Ah, right, that could well explain it.

@zooba zooba merged commit f14c28f into python:master Sep 20, 2018
@zooba zooba deleted the bpo-34011 branch September 20, 2018 20:38
zooba added a commit to zooba/cpython that referenced this pull request Sep 20, 2018
@pablogsal
Copy link
Member

pablogsal commented Nov 7, 2018

This buildbot is failing when raising when creating subprocess.CalledProcessError:

https://buildbot.python.org/all/#/builders/40/builds/1135/steps/3/logs/stdio

test_defaults (test.test_venv.BasicTest) ... ok
test_executable (test.test_venv.BasicTest) ... ok
test_executable_symlinks (test.test_venv.BasicTest) ... skipped 'Needs symlinks'
test_isolation (test.test_venv.BasicTest) ... ok
test_overwrite_existing (test.test_venv.BasicTest) ... ok
test_prefixes (test.test_venv.BasicTest) ... ok
test_prompt (test.test_venv.BasicTest) ... ok
test_symlinking (test.test_venv.BasicTest) ... skipped 'Needs symlinks'
test_unicode_in_batch_file (test.test_venv.BasicTest) ... ERROR
test_unoverwritable_fails (test.test_venv.BasicTest) ... ok
test_upgrade (test.test_venv.BasicTest) ... ok
test_devnull (test.test_venv.EnsurePipTest) ... ok
test_explicit_no_pip (test.test_venv.EnsurePipTest) ... ok
test_no_pip_by_default (test.test_venv.EnsurePipTest) ... ok
test_with_pip (test.test_venv.EnsurePipTest) ... ok
======================================================================
ERROR: test_unicode_in_batch_file (test.test_venv.BasicTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_venv.py", line 302, in test_unicode_in_batch_file
    out, err = check_output(
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_venv.py", line 37, in check_output
    raise subprocess.CalledProcessError(
TypeError: __init__() takes from 3 to 5 positional arguments but 6 were given
----------------------------------------------------------------------

I will prepare a PR fixing this

@pablogsal
Copy link
Member

@pablogsal
Copy link
Member

pablogsal commented Nov 7, 2018

@zooba @vsajip There may be more problems with this Pull Request than just the problem above, can you take a look at the buildbots?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants