Skip to content

gh-94512: Fix forced arg format in AC-processed overlapped #94516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 28, 2022

Conversation

arhadthedev
Copy link
Member

@arhadthedev arhadthedev commented Jul 2, 2022

Please note that this PR redefines a local hierarchy of converters by inserting a universal pointer converter as a common root.

@arhadthedev
Copy link
Member Author

HANDLE_converter must choose between int on POSIX and void * on Windows; draft this PR until I'll sort out how to properly implement it.

@arhadthedev arhadthedev marked this pull request as draft July 2, 2022 21:36
@arhadthedev
Copy link
Member Author

arhadthedev commented Jul 2, 2022

False alarm, underlying pointer processing already does this.

@arhadthedev arhadthedev marked this pull request as ready for review July 2, 2022 21:56
This reverts commit af8f603.
@zooba zooba merged commit 26d4af0 into python:main Jul 28, 2022
@arhadthedev arhadthedev deleted the clinic-overlapped-deformat branch July 29, 2022 02:25
@gvanrossum
Copy link
Member

Did this cause some GitHub warnings? E.g. at the end of https://github.com/python/cpython/pull/95253/files there are some warnings like

 Modules/clinic/overlapped.c.h#L40
'=': 'ULONG_PTR' differs in levels of indirection from 'void *' [D:\a\cpython\cpython\PCbuild\_overlapped.vcxproj]

@arhadthedev
Copy link
Member Author

arhadthedev commented Aug 1, 2022

@gvanrossum A two-step fix is ready:

@zooba
Copy link
Member

zooba commented Aug 1, 2022

Can we quick fix it by making AC generate casts for uintptr_t?

@arhadthedev
Copy link
Member Author

@zooba I agree with a quick fix here and now. Here it is:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants