gh-94404: makesetup: use correct CFLAGS and macOS workaround #94405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``makesetup`` now works around an issue with sed on macOS and uses correct CFLAGS for object files that end up in a shared extension.
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 29, 2022
…ythonGH-94405) ``makesetup`` now works around an issue with sed on macOS and uses correct CFLAGS for object files that end up in a shared extension. (cherry picked from commit 5150cbc) Co-authored-by: Christian Heimes <christian@python.org>
|
GH-94406 is a backport of this pull request to the 3.11 branch. |
miss-islington
added a commit
that referenced
this pull request
Jun 29, 2022
``makesetup`` now works around an issue with sed on macOS and uses correct CFLAGS for object files that end up in a shared extension. (cherry picked from commit 5150cbc) Co-authored-by: Christian Heimes <christian@python.org>
gvanrossum
pushed a commit
to gvanrossum/cpython
that referenced
this pull request
Jun 30, 2022
…ythonGH-94405) ``makesetup`` now works around an issue with sed on macOS and uses correct CFLAGS for object files that end up in a shared extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makesetupnow works around an issue with sed on macOS and uses correctCFLAGS for object files that end up in a shared extension.