Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33649: More improvements #9439

Merged
merged 9 commits into from
Sep 20, 2018
Merged

bpo-33649: More improvements #9439

merged 9 commits into from
Sep 20, 2018

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Sep 20, 2018 •
edited by bedevere-bot
Loading

@1st1 1st1 requested a review from willingc September 20, 2018 05:58
@1st1 1st1 requested a review from asvetlov as a code owner September 20, 2018 05:58
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting merge labels Sep 20, 2018
willingc
willingc reviewed Sep 20, 2018
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments to make these concepts easier for those new to asyncio. Thanks @1st1

asvetlov
asvetlov approved these changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@1st1 1st1 merged commit e247b46 into python:master Sep 20, 2018
@miss-islington
Copy link
Contributor

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@1st1 1st1 deleted the imp branch September 20, 2018 16:44
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 20, 2018
@1st1 @miss-islington
bpo-33649: More improvements (pythonGH-9439)
31301b1 
(cherry picked from commit e247b46)

Co-authored-by: Yury Selivanov <yury@magic.io>
@bedevere-bot
Copy link

GH-9454 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Sep 20, 2018
@miss-islington @1st1
bpo-33649: More improvements (GH-9439)
8e5ef58 
(cherry picked from commit e247b46)

Co-authored-by: Yury Selivanov <yury@magic.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc left review comments

@asvetlov asvetlov asvetlov approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@1st1 @miss-islington @bedevere-bot @asvetlov @willingc @the-knights-who-say-ni