Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34746: Fix stop -> close #9437

Merged
merged 1 commit into from
Sep 20, 2018
Merged

bpo-34746: Fix stop -> close #9437

merged 1 commit into from
Sep 20, 2018

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Sep 20, 2018 •
edited by bedevere-bot
Loading

@1st1 1st1 requested a review from asvetlov as a code owner September 20, 2018 05:06
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Sep 20, 2018
@1st1 1st1 merged commit ffef50f into python:master Sep 20, 2018
@miss-islington
Copy link
Contributor

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@1st1 1st1 deleted the fix branch September 20, 2018 05:17
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 20, 2018
@1st1 @miss-islington
bpo-34746: Fix stop -> close (pythonGH-9437)
88bc684 
(cherry picked from commit ffef50f)

Co-authored-by: Yury Selivanov <yury@magic.io>
@bedevere-bot
Copy link

GH-9438 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Sep 20, 2018
@miss-islington @1st1
bpo-34746: Fix stop -> close (GH-9437)
4fe8dc6 
(cherry picked from commit ffef50f)

Co-authored-by: Yury Selivanov <yury@magic.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1st1 @miss-islington @bedevere-bot @the-knights-who-say-ni