Skip to content

[3.10] gh-94245: Fix pickling and copying of typing.Tuple[()] #94260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2022
Merged

[3.10] gh-94245: Fix pickling and copying of typing.Tuple[()] #94260

merged 1 commit into from
Jun 25, 2022

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jun 25, 2022 •
edited by bedevere-bot
Loading

It is an alternate PR, which only fixes pickling and copying typing.Tuple[()], without affecting its __args__.

@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Jun 25, 2022
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jun 25, 2022
Closed
@JelleZijlstra JelleZijlstra changed the title gh-94245: Fix pickling and copying of typing.Tuple[()] [3.10] gh-94245: Fix pickling and copying of typing.Tuple[()] Jun 25, 2022
JelleZijlstra
JelleZijlstra approved these changes Jun 25, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'd prefer this over backporting your other change, since it's less disruptive.

@serhiy-storchaka serhiy-storchaka merged commit 75dda3b into python:3.10 Jun 25, 2022
@serhiy-storchaka serhiy-storchaka deleted the typing-empty-tuple-pickle-copy-3.10 branch June 25, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @JelleZijlstra @gvanrossum @Fidget-Spinner @bedevere-bot