Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-74953: PyThread_acquire_lock_timed() recomputes timeout #93946

Closed
wants to merge 1 commit into from
Closed

gh-74953: PyThread_acquire_lock_timed() recomputes timeout #93946

wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

The mutex with conditional variable implementation of lock now
recomputes the timeout if acquire(timeout=timeout) is interrupted by
a signal.

@vstinner vstinner marked this pull request as ready for review June 20, 2022 14:20
@vstinner
Copy link
Member Author

macOS job failed with:

0:05:19 load avg: 9.67 [ 99/436/1] test_concurrent_futures failed (env changed) (3 min 15 sec)
(...)
Warning -- sys.stderr was modified by test_concurrent_futures
Warning --   Before: <_io.StringIO object at 0x10d1a5590>
Warning --   After:  <_io.StringIO object at 0x10d822cb0>

I don't know if it's related to the PR.

@vstinner
Copy link
Member Author

PR rebased on main to get fixes for unrelated compiler warnings.

The mutex with conditional variable implementation of lock now
recomputes the timeout if acquire(timeout=timeout) is interrupted by
a signal.
@vstinner
Copy link
Member Author

I'm no longer convinced that this change is needed:

  • On Linux, USE_SEMAPHORES macro is defined: use sem_clockwait(), or sem_timedwait()
  • If I manually undefine the USE_SEMAPHORES macro to use mutex+condvar implementation, I failed to interrupt pthread_cond_timedwait() with a signal. If it's called with a timeout of 5 seconds and an interrupt is received in 1 second, pthread_cond_timedwait() function does not return EINTR but blocks for 5 seconds.

Locks used in Python call PyThread_acquire_lock_timed() with intr_flag=1: if a function returns EINTR, it returns immediately, the caller checks for signals, and then calls again the function to try again to acquire to lock with a re-computed timeout.

I close my PR. But I wrote PR #94056 to clean-up the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants