gh-74953: PyThread_acquire_lock_timed() recomputes timeout#93946
Closed
vstinner wants to merge 1 commit intopython:mainfrom
vstinner:lock_timeout
Closed
gh-74953: PyThread_acquire_lock_timed() recomputes timeout#93946vstinner wants to merge 1 commit intopython:mainfrom vstinner:lock_timeout
vstinner wants to merge 1 commit intopython:mainfrom
vstinner:lock_timeout
Conversation
Member
Author
|
macOS job failed with: I don't know if it's related to the PR. |
Member
Author
|
PR rebased on main to get fixes for unrelated compiler warnings. |
The mutex with conditional variable implementation of lock now recomputes the timeout if acquire(timeout=timeout) is interrupted by a signal.
Member
Author
|
I'm no longer convinced that this change is needed:
Locks used in Python call PyThread_acquire_lock_timed() with intr_flag=1: if a function returns EINTR, it returns immediately, the caller checks for signals, and then calls again the function to try again to acquire to lock with a re-computed timeout. I close my PR. But I wrote PR #94056 to clean-up the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mutex with conditional variable implementation of lock now
recomputes the timeout if acquire(timeout=timeout) is interrupted by
a signal.