Skip to content

Conversation

LostBenjamin
Copy link
Contributor

Hi,

This pull request is a fix to a potential variable misuse bug at Lib/test/test_functools.py. Please check the changes.

Best,
Jingxuan

@LostBenjamin LostBenjamin requested a review from rhettinger as a code owner June 17, 2022 10:16
@ghost
Copy link

ghost commented Jun 17, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jun 17, 2022
@CharlieZhao95
Copy link
Contributor

Maybe you could read the Python Developer's Guide first to make sure your PR is formatted correctly. The doc will also tell you how to sign the CLA.

@LostBenjamin
Copy link
Contributor Author

This PR only changes one line of code. No format is better than taking a brief look at the changed line.

I tried to sign the CLA for multiple times. However, whenever I clicked SIGN IN WITH GITHUB TO AGREE, it shows Thank you for authorizing our application, but the CLA must be signed by the users who contributed to the PR. Authors emails are: LostBenjamin@users.noreply.github.com..

@hauntsaninja
Copy link
Contributor

hauntsaninja commented Jun 20, 2022

Thanks for spotting this! Can you reauthor the commit using the email ID you signed the CLA with?

@LostBenjamin
Copy link
Contributor Author

@hauntsaninja Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants