Skip to content

gh-91404: Revert "bpo-23689: re module, fix memory leak when a match is terminated by a signal or memory allocation failure (GH-32283)"#93559

Closed
ghost wants to merge 2 commits intomainfrom
unknown repository
Closed

gh-91404: Revert "bpo-23689: re module, fix memory leak when a match is terminated by a signal or memory allocation failure (GH-32283)"#93559
ghost wants to merge 2 commits intomainfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jun 7, 2022

In nesting repeats, a repeat context may have multiple active existences at the same time.
So 6e3eee5's method is wrong.

…ted by a signal or memory allocation failure (GH-32283)"

This reverts commit 6e3eee5.
@gpshead
Copy link
Member

gpshead commented Jun 15, 2022

I created a similar PR as I hadn't seen this one mentioned on the #91404 issue.

At a quick glance without diving deep to compare diffs, the MAGIC constants are not being updated by this PR while I decided to do that in mine.

@ghost ghost closed this Jun 16, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants