Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-61585: Clarify import scope in modules tutorial #93455

Merged
merged 4 commits into from
Jun 28, 2022
Merged

gh-61585: Clarify import scope in modules tutorial #93455

merged 4 commits into from
Jun 28, 2022

Conversation

slateny
Copy link
Contributor

@slateny slateny commented Jun 3, 2022

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jun 3, 2022
AA-Turner
AA-Turner reviewed Jun 8, 2022
View reviewed changes
@slateny @AA-Turner
Use namespace instead of symbol table
52ac1f8 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@AA-Turner
Copy link
Member

Should the other four usages of symbol table be adjusted in this PR?

A

@CAM-Gerlach
Copy link
Member

Should the other four usages of symbol table be adjusted in this PR?

That might be a little scope-creepy, but since all the usages in this file are fairly nearby this one, that would avoid any introduced inconsistency, if @slateny is okay with doing so.

If so, then I suggest making the first reference in the previous section a link to the term :term:`Namespace`, and then the move the :term:`namespace` (see :ref:`tut-scopes` for more details). line to the first usage (which describes it in some detail) in this section. That would be a better place to put it anyway, really, since it explicitly introduces the basic concept.

CAM-Gerlach
CAM-Gerlach reviewed Jun 15, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the wording of the lines to match the new word used, as the old dict wasn't really grammatically appropriate after the change. Otherwise, LGTM, thanks.

@slateny @CAM-Gerlach
Change 'enters' to 'adds'
c37485f 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
CAM-Gerlach
CAM-Gerlach approved these changes Jun 25, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay—LGTM now from my end, thanks!

@JelleZijlstra JelleZijlstra self-requested a review June 25, 2022 01:43
@JelleZijlstra JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jun 25, 2022
@JelleZijlstra JelleZijlstra self-assigned this Jun 25, 2022
@ambv ambv merged commit 4b854b7 into python:main Jun 28, 2022
@miss-islington
Copy link
Contributor

Thanks @slateny for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 28, 2022
@slateny @miss-islington
pythongh-61585: Clarify import scope in modules tutorial (pythonGH-93455
d9bef8a 
)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 4b854b7)

Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
@bedevere-bot
Copy link

GH-94373 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 28, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 28, 2022
@slateny @miss-islington
pythongh-61585: Clarify import scope in modules tutorial (pythonGH-93455
4a178bd 
)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 4b854b7)

Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
@bedevere-bot
Copy link

GH-94374 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 28, 2022
ambv pushed a commit that referenced this pull request Jun 28, 2022
@miss-islington
gh-61585: Clarify import scope in modules tutorial (GH-93455) (GH-94373)
3937dbf 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
(cherry picked from commit 4b854b7)
ambv pushed a commit that referenced this pull request Jun 28, 2022
@miss-islington
gh-61585: Clarify import scope in modules tutorial (GH-93455) (GH-94374)
d11b010 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
(cherry picked from commit 4b854b7)
@ambv ambv mentioned this pull request Jun 28, 2022
Closed
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jun 30, 2022
@slateny @AA-Turner
@CAM-Gerlach @gvanrossum
pythongh-61585: Clarify import scope in modules tutorial (pythonGH-93455
b5942e9 
)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@slateny slateny deleted the s/61585 branch September 24, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@DanielNoord DanielNoord DanielNoord approved these changes

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@slateny @AA-Turner @CAM-Gerlach @miss-islington @bedevere-bot @JelleZijlstra @DanielNoord @ambv