Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the more elaborate multiprocessing example in the logging cookbook #9326

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

geryogam
Copy link
Contributor

@geryogam geryogam commented Sep 14, 2018

This pull request will:

  • remove the unused detailed formatter in the config_initial dictionary;
  • modify the implementation of the handle method of the MyHandler class to consider the loggers' levels in the config_listener dictionary.

@vsajip
Copy link
Member

vsajip commented Sep 15, 2018

Please revert the whitespace / PEP-8 changes, which are not applicable to the specific example we discussed. Just keep the changes within the specific example script.

@vsajip vsajip changed the title Improve the more elaborate multiprocessing example Improve the more elaborate multiprocessing example in the logging cookbook Sep 15, 2018
…kbook

* Remove the unused detailed formatter in the config_initial dictionary.
* Modify the implementation of the  method of the MyHandler class to consider the loggers' levels in the config_listener dictionary.
@geryogam
Copy link
Contributor Author

@vsajip

Please revert the whitespace / PEP-8 changes, which are not applicable to the specific example we discussed. Just keep the changes within the specific example script.

Done.

@vsajip
Copy link
Member

vsajip commented Sep 17, 2018

Done.

OK, thanks. Just as a general suggestion - please avoid making stylistic changes which aren't specific to the issue being addressed. For example, you have re-ordered some dictionary keys, added blank lines and removed trailing commas, where none of these changes were needed in order to (a) remove the unused formatter and (b) respect the logger level while dispatching events. While I'm not asking you to revert these, it's generally best to minimise noise in PRs - because it makes life easier for reviewers not to have to review stylistic changes which have no impact on the functionality changes being addressed.

@vsajip vsajip merged commit 5b3cbcd into python:master Sep 25, 2018
@geryogam geryogam deleted the patch-1 branch September 25, 2018 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants