Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify PyInit_timezone #9323

Merged
merged 1 commit into from
Sep 14, 2018
Merged

simplify PyInit_timezone #9323

merged 1 commit into from
Sep 14, 2018
+15 −68

Conversation

benjaminp
Copy link
Contributor

@benjaminp benjaminp commented Sep 14, 2018 •
edited
Loading

Assume tzname exists. Only use a hack to compute altzone if it's not defined.

@benjaminp benjaminp changed the title simplify tz simplify PyInit_timezone Sep 14, 2018
@benjaminp benjaminp closed this Sep 14, 2018
@benjaminp benjaminp reopened this Sep 14, 2018
@benjaminp benjaminp merged commit afde1c1 into master Sep 14, 2018
@benjaminp benjaminp deleted the benjamin-simplify-tz branch September 14, 2018 23:21
@pablogsal
Copy link
Member

pablogsal commented Sep 17, 2018 •
edited
Loading

This PR broke the FreeBSD buildbot:

https://bugs.python.org/issue34715
https://buildbot.python.org/all/#/builders/87/builds/1434

@vstinner
Copy link
Member

PR #9366 reverts this change.

vstinner added a commit that referenced this pull request Sep 17, 2018
@vstinner
bpo-34715: Revert "Simplify PyInit_timezone. (GH-9323)" (GH-9366)
1fb399b 
This reverts commit afde1c1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@benjaminp @pablogsal @vstinner @the-knights-who-say-ni @bedevere-bot