Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-89653: PEP 670: Convert unicodeobject.h macros to functions #92648

Merged
merged 1 commit into from
May 11, 2022
Merged

gh-89653: PEP 670: Convert unicodeobject.h macros to functions #92648

merged 1 commit into from
May 11, 2022

Conversation

vstinner
Copy link
Member

Convert the following Unicode macros to static inline functions.

Surrogate functions:

  • Py_UNICODE_IS_SURROGATE()
  • Py_UNICODE_IS_HIGH_SURROGATE()
  • Py_UNICODE_IS_LOW_SURROGATE()
  • Py_UNICODE_HIGH_SURROGATE()
  • Py_UNICODE_LOW_SURROGATE()
  • Py_UNICODE_JOIN_SURROGATES()

"Is" functions:

  • Py_UNICODE_ISALNUM()
  • Py_UNICODE_ISSPACE()

In the implementation of these functions, the character type is now
well defined to Py_UCS4.

Convert the following Unicode macros to static inline functions.

Surrogate functions:

* Py_UNICODE_IS_SURROGATE()
* Py_UNICODE_IS_HIGH_SURROGATE()
* Py_UNICODE_IS_LOW_SURROGATE()
* Py_UNICODE_HIGH_SURROGATE()
* Py_UNICODE_LOW_SURROGATE()
* Py_UNICODE_JOIN_SURROGATES()

"Is" functions:

* Py_UNICODE_ISALNUM()
* Py_UNICODE_ISSPACE()

In the implementation of these functions, the character type is now
well defined to Py_UCS4.
@vstinner
Copy link
Member Author

cc @erlend-aasland

Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This is a nice improvement :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants