Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92417: subprocess docs: remove note on compatibility with Python <3.5 #92538

Merged
merged 1 commit into from
May 19, 2022
Merged

gh-92417: subprocess docs: remove note on compatibility with Python <3.5 #92538

merged 1 commit into from
May 19, 2022

Conversation

AlexWaygood
Copy link
Member

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 9, 2022
@AlexWaygood AlexWaygood added skip news needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels May 9, 2022
@AlexWaygood AlexWaygood mentioned this pull request May 9, 2022
Closed
hugovk
hugovk approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

rhettinger
rhettinger reviewed May 9, 2022
View reviewed changes
Doc/library/subprocess.rst
@@ -33,9 +33,6 @@ The recommended approach to invoking subprocesses is to use the :func:`run`
function for all use cases it can handle. For more advanced use cases, the
underlying :class:`Popen` interface can be used directly.

The :func:`run` function was added in Python 3.5; if you need to retain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We normally keep the notes. on when a function was added.

There are many packages that need to maintain cross-version support even if we don't support the old versions. This information is critical for them.

Copy link
Member Author

@AlexWaygood AlexWaygood May 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .. versionadded:: 3.5 note for subprocess.run(), on line 103 of this file, is not touched by this PR (and I would not want to remove it). This PR proposes to remove an additional note, which seems to me to be overly prominent now that 3.4 has been end-of-life for a long time.

@rhettinger rhettinger removed the needs backport to 3.9 only security fixes label May 9, 2022
@AlexWaygood AlexWaygood removed the needs backport to 3.10 only security fixes label May 9, 2022
@ambv ambv added the needs backport to 3.10 only security fixes label May 19, 2022
@ambv
Copy link
Contributor

ambv commented May 19, 2022

Backporting to 3.10 for consistency with comment in #92544 (comment).

@ambv ambv merged commit 84b8600 into python:main May 19, 2022
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-92972 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2022
@AlexWaygood @miss-islington
pythongh-92417: subprocess docs: remove note on compatibility with …
8f42268 
…Python <3.5 (pythonGH-92538)

(cherry picked from commit 84b8600)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 19, 2022
@bedevere-bot
Copy link

GH-92973 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2022
@AlexWaygood @miss-islington
pythongh-92417: subprocess docs: remove note on compatibility with …
ecbed9a 
…Python <3.5 (pythonGH-92538)

(cherry picked from commit 84b8600)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AlexWaygood AlexWaygood deleted the patch-1 branch May 19, 2022 15:33
ambv pushed a commit that referenced this pull request May 19, 2022
@miss-islington @AlexWaygood
gh-92417: subprocess docs: remove note on compatibility with Python…
3d47035 
… <3.5 (GH-92538) (GH-92973)

(cherry picked from commit 84b8600)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
ambv pushed a commit that referenced this pull request May 19, 2022
@miss-islington @AlexWaygood
gh-92417: subprocess docs: remove note on compatibility with Python…
de97d82 
… <3.5 (GH-92538) (GH-92972)

(cherry picked from commit 84b8600)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger rhettinger left review comments

@hugovk hugovk hugovk approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AlexWaygood @ambv @miss-islington @bedevere-bot @hugovk @rhettinger @serhiy-storchaka