-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-92417: importlib
docs: remove references to unsupported Python versions
#92424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from one minor textual nit (that wasn't introduced by this PR, but on a line touched by it), I checked over the importlib* docs and there indeed doesn't appear to be remaining references to unsupported versions, so LGTM.
One note, though—will only changes referring to Python versions that were unsupported at the time the backport target was released be backported? It seems a little odd to actively remove docs content that refers to versions supported at the time an older bugfix version just because an EoL date was later reached, as well as extra work.
It would seem to make more sense to have a consistent policy of just mentioning the Python versions supported as of the release of the target version, rather than going through and updating all the bugfix, pre-release and future docs at the moment an older version goes EoL, since otherwise up to 4 sets of docs need to be updated with every EoL on a rigid schedule, as opposed to just one set per release at any point between branching the previous release and the current release.
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
Agreed with CAM, this should only get backported to 3.11 as Alex already edited. |
Thanks @AlexWaygood for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
GH-92979 is a backport of this pull request to the 3.11 branch. |
…thon versions (pythonGH-92424) Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM> (cherry picked from commit 70aa1b9) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This change also needs to get backported to importlib_metadata. Done in python/importlib_metadata@c68e382f7c. |
#92417