Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-91325: Skip Stable ABI checks with Py_TRACE_REFS special build #92046

Merged
merged 2 commits into from
Jan 29, 2024
Merged

gh-91325: Skip Stable ABI checks with Py_TRACE_REFS special build #92046

merged 2 commits into from
Jan 29, 2024

Conversation

encukou
Copy link
Member

@encukou encukou commented Apr 29, 2022 •
edited by bedevere-app bot
Loading

Py_TRACE_REFS is not compatible with Py_LIMITED_API nor with the stable ABI.

@encukou
Skip Stable ABI checks with Py_TRACE_REFS special build
0fa4e68 
This build is not compatible with Py_LIMITED_API nor with
the stable ABI.
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 29, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 0fa4e68 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 29, 2022
@encukou encukou mentioned this pull request Apr 29, 2022
Closed
kumaraditya303
kumaraditya303 previously requested changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are merge conflicts.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

And if you don't make the requested changes, you will be poked with soft cushions!

@encukou
Copy link
Member Author

encukou commented Dec 14, 2022

... where are my soft cushions, @bedevere-bot ?

@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 1adabea 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2024
@encukou
Copy link
Member Author

encukou commented Jan 23, 2024

No soft cushions, so I've resolved the conflict.

@encukou
Copy link
Member Author

encukou commented Jan 23, 2024

I have made the requested changes; please review again

@encukou encukou dismissed kumaraditya303’s stale review January 24, 2024 12:54

There are no more conflicts.

@encukou encukou merged commit 15fe8ce into python:main Jan 29, 2024
109 of 112 checks passed
@encukou encukou deleted the stable-abi-trace-refs branch January 29, 2024 15:45
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@encukou @aisk
pythongh-91325: Skip Stable ABI checks with Py_TRACE_REFS special bui…
3e1e4cf 
…ld (pythonGH-92046)

Skip Stable ABI checks with Py_TRACE_REFS special build

This build is not compatible with Py_LIMITED_API nor with
the stable ABI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@encukou @bedevere-bot @kumaraditya303