Skip to content

[3.10] Revert "[3.10] bpo-47104: Rewrite asyncio.to_thread tests to use IsolatedAsyncioTestCase (GH-32086)" #91667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.10] Revert "[3.10] bpo-47104: Rewrite asyncio.to_thread tests to use IsolatedAsyncioTestCase (GH-32086)" #91667

wants to merge 1 commit into from

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Apr 18, 2022 •
edited
Loading

Reverts #32087

See #91260

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Apr 18, 2022
@kumaraditya303 kumaraditya303 changed the title Revert "[3.10] bpo-47104: Rewrite asyncio.to_thread tests to use IsolatedAsyncioTestCase (GH-32086)" [3.10] Revert "[3.10] bpo-47104: Rewrite asyncio.to_thread tests to use IsolatedAsyncioTestCase (GH-32086)" Apr 18, 2022
@kumaraditya303 kumaraditya303 mentioned this pull request Apr 18, 2022
Closed
@AlexWaygood AlexWaygood mentioned this pull request Apr 18, 2022
Merged
@gpshead gpshead added the needs backport to 3.9 only security fixes label Apr 19, 2022
@gpshead
Copy link
Member

gpshead commented Apr 19, 2022

I have a couple ideas regarding #91676, let's hold off on submitting this for at least another day to see if I can fix the actual cause behind this.

workaround today for those CI fails and blocks merge on: click the rerun failed button. usually you'll get a good blocking ubuntu run within a couple of retries. (macos isn't blocking)

@gpshead gpshead mentioned this pull request Apr 19, 2022
Merged
@kumaraditya303
Copy link
Contributor Author

Superseded by #91680

@kumaraditya303 kumaraditya303 deleted the revert-32087-backport-ff619c7-3.10 branch April 19, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees
No one assigned
Labels
awaiting review needs backport to 3.9 only security fixes tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumaraditya303 @gpshead @bedevere-bot