Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-20180: convert most of itertoolsmodule.c to use Argument Clinic #9164

Merged
merged 11 commits into from
Sep 11, 2018
Merged

bpo-20180: convert most of itertoolsmodule.c to use Argument Clinic #9164

merged 11 commits into from
Sep 11, 2018

Conversation

taleinat
Copy link
Contributor

@taleinat taleinat commented Sep 11, 2018 •
edited by bedevere-bot
Loading

This is a followup to PRs #4117 and #4170.

As requested by @rhettinger, this PR:

  • keeps doc-strings unchanged
  • doesn't convert special dunder methods such as __reduce__ and __setstate__
  • keeps variable names unchanged e.g. predicate as func: object
  • doesn't move anything around, only adding a required list of static PyTypeObject declarations at the top

Since AC requires the doc-string to begin with a single summary line, I've kept most of those unchanged, despite in some cases exceeding 79 characters in length. @rhettinger, what should be done with those?

https://bugs.python.org/issue20180

@taleinat taleinat mentioned this pull request Sep 11, 2018
Closed
taleinat and others added 2 commits September 11, 2018 17:51
@taleinat
bpo-20180: AC convert itertools: two minor fixes
77e052e 
* add back accidentally removed static PyTypeObject declaration
* remove no longer used PyDoc_STRVAR doc-string definition
@rhettinger
Fix minor spacing issues.
07eb3a9
@rhettinger rhettinger merged commit c4bccd3 into python:master Sep 11, 2018
@methane methane mentioned this pull request Apr 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taleinat @rhettinger @the-knights-who-say-ni @bedevere-bot