-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-34605: Avoid master/slave terms #9101
Conversation
* Replace "master process" with "parent process" * Replace "master option mappings" with "main option mappings" * Replace "master pattern object" with "main pattern object" * ssl: replace "master" with "server" * And some other similar changes
@@ -223,7 +223,7 @@ def initialize_options(self): | |||
|
|||
def finalize_options(self): | |||
"""Finalizes options.""" | |||
# This method (and its pliant slaves, like 'finalize_unix()', | |||
# This method (and its pliant childs, like 'finalize_unix()', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this reads better as children
. Although pliant
isn't a very common word, and I'm not sure how it's being used here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, maybe I should have waited longer before merging this one :-( I'm wasn't 100% sure between "childs" and "children". Sorry, english is not my first language. I created PR #9102 to replace childs with children.
I'm not sure what do you propose for pliant. In case of doubt, I leave it unchanged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I Googled a bit and it seems "pliant slave" is an old-fashioned way to refer to slaves, and even more demeaning than just "slave" -- I presume it was meant ironically by the original author. We should really replace the entire construct "pliant slaves" with a more neutral term. I don't think "children" is the right term -- I propose "helpers".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gvanrossum, @ericvsmith: Ok, I created #9195
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gvanrossum it's in the same vein as compliant.
This comment has been minimized.
This comment has been minimized.
There is no point in continuing the debate. We’ve all had our say. If you
want to keep talking, go to Twitter.
On Tue, Sep 11, 2018 at 9:21 PM towerd ***@***.***> wrote:
In "Oxford Advanced Learners Dictionary", slave has an entry:
(specialist) a device that is directly controlled by another one
Words shall be interpreted in certain context. Otherwise, should every
word be interpreted literally? If one is named Cook, is he really a cook?
What's more, if slave can remind someone of bad things, shall every word
with some bad meaning be avoided? Stones can be related to weapon, sea can
drown people, shall these words be banned? The names of famous campus
killers, shall they be avoided to be used as names of new born babies,
because these names are used by killers'?
I'm afraid this seems like the "literary inquisition" that happened
numerous times in history. In those cases, word were interpreted in certain
ways deliberately, totally ignoring their context, and the related persons
were judged criminal just because they said those words.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9101 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACwrMiZ_OGkrJcqQ2ZHNZ4fklFjRyF3gks5uaIuzgaJpZM4WfAz6>
.
--
--Guido (mobile)
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just few side comments.
@@ -72,7 +72,7 @@ class Verbose(Exception): | |||
pass | |||
|
|||
class Pattern: | |||
# master pattern object. keeps track of global attributes | |||
# main pattern object. keeps track of global attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually both wordings are wrong. This class doesn't represent a pattern object in any sense. I'll open a separate issue for this.
@@ -1,7 +1,7 @@ | |||
This directory contains a number of Python programs that are useful | |||
while building or extending Python. | |||
|
|||
buildbot Batchfiles for running on Windows buildslaves. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, "buildslave" was a term used in the Buildbot documentation: http://docs.buildbot.net/0.8.5/manual/cfg-buildslaves.html. In recent versions it was replaced with "worker": http://docs.buildbot.net/1.4.0/manual/cfg-workers.html.
In distutils.command.install, replace "pliant children" (previously, it was "pliant slaves") with "helpers". <!-- issue-number: [bpo-34605](https://www.bugs.python.org/issue34605) --> https://bugs.python.org/issue34605 <!-- /issue-number -->
https://bugs.python.org/issue34605