Skip to content

Simplified implementation of _sre.ascii_iscased(). #9097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2018
Merged

Simplified implementation of _sre.ascii_iscased(). #9097

merged 3 commits into from
Sep 12, 2018

Conversation

sir-sigurd
Copy link
Contributor

No description provided.

serhiy-storchaka
serhiy-storchaka reviewed Sep 10, 2018
View reviewed changes
Modules/_sre.c Outdated
@@ -293,7 +288,7 @@ _sre_ascii_iscased_impl(PyObject *module, int character)
/*[clinic end generated code: output=4f454b630fbd19a2 input=9f0bd952812c7ed3]*/
{
unsigned int ch = (unsigned int)character;
return ch != sre_lower_ascii(ch) || ch != sre_upper_ascii(ch);
return ch <= 'z' && Py_ISALPHA(ch);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use 127 instead of 'z'.

benjaminp
benjaminp requested changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@benjaminp benjaminp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that < 128 would be better.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@sir-sigurd
Copy link
Contributor Author

@serhiy-storchaka @benjaminp
I used <= 'z' to allow fast path for values between 'z' and 128, i'm not sure why < 128 would be better.

@serhiy-storchaka
Copy link
Member

Performance is not critical here, but readability matters. It took a while for me to figure out why this code is written in such way and to ensure that it is correct. It can be looking more cryptic for other readers. The meaning of < 128 is more clear: it is for ASCII only.

@sir-sigurd
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@zhangyangyu, @benjaminp: please review the changes made to this pull request.

@serhiy-storchaka serhiy-storchaka merged commit 7f0d59f into python:master Sep 12, 2018
@sir-sigurd sir-sigurd deleted the sre-ascii-iscased branch September 12, 2018 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminp benjaminp benjaminp requested changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@zhangyangyu zhangyangyu zhangyangyu approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sir-sigurd @bedevere-bot @serhiy-storchaka @benjaminp @zhangyangyu @the-knights-who-say-ni