[3.7] bpo-33613, test_semaphore_tracker_sigint: fix race condition (GH-7850) #9055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…H-7850) Fail `test_semaphore_tracker_sigint` if no warnings are expected and one is received. Fix race condition when the child receives SIGINT before it can register signal handlers for it. The race condition occurs when the parent calls `_semaphore_tracker.ensure_running()` (which in turn spawns the semaphore_tracker using `_posixsubprocess.fork_exec`), the child registers the signal handlers and the parent tries to kill the child. What seem to happen is that in some slow systems, the parent sends the signal to kill the child before the child protects against the signal. (cherry picked from commit ec74d18) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
|
Rejected. This isn't fixing a user-visible bug. |
|
@pablogsal and @pitrou: Backport status check is done, and it's a failure ❌ . |
1 similar comment
|
@pablogsal and @pitrou: Backport status check is done, and it's a failure ❌ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail
test_semaphore_tracker_sigintif no warnings are expected and one is received.Fix race condition when the child receives SIGINT before it can register signal handlers for it.
The race condition occurs when the parent calls
_semaphore_tracker.ensure_running()(which in turn spawns thesemaphore_tracker using
_posixsubprocess.fork_exec), the childregisters the signal handlers and the parent tries to kill the child.
What seem to happen is that in some slow systems, the parent sends the
signal to kill the child before the child protects against the signal.
(cherry picked from commit ec74d18)
Co-authored-by: Pablo Galindo Pablogsal@gmail.com
https://bugs.python.org/issue33613