Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34456: pickle: Add missing NULL check to save_global() #8851

Merged
merged 1 commit into from
Aug 22, 2018
Merged

bpo-34456: pickle: Add missing NULL check to save_global() #8851

merged 1 commit into from
Aug 22, 2018

Conversation

izbyshev
Copy link
Contributor

@izbyshev izbyshev commented Aug 21, 2018 •
edited by bedevere-bot
Loading

Reported by Svace static analyzer.

https://bugs.python.org/issue34456

@serhiy-storchaka serhiy-storchaka added skip news type-bug An unexpected behavior, bug, or error needs backport to 3.6 labels Aug 22, 2018
@serhiy-storchaka serhiy-storchaka merged commit f8c06b0 into python:master Aug 22, 2018
@miss-islington
Copy link
Contributor

Thanks @izbyshev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2018
@miss-islington
bpo-34456: pickle: Add missing NULL check to save_global(). (pythonGH…
1150397 
…-8851)

Reported by Svace static analyzer.
(cherry picked from commit f8c06b0)

Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
@bedevere-bot
Copy link

GH-8853 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-8854 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2018
@miss-islington
bpo-34456: pickle: Add missing NULL check to save_global(). (pythonGH…
d79151d 
…-8851)

Reported by Svace static analyzer.
(cherry picked from commit f8c06b0)

Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
miss-islington added a commit that referenced this pull request Aug 22, 2018
@miss-islington
bpo-34456: pickle: Add missing NULL check to save_global(). (GH-8851)
3152bc3 
Reported by Svace static analyzer.
(cherry picked from commit f8c06b0)

Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
miss-islington added a commit that referenced this pull request Aug 22, 2018
@miss-islington
bpo-34456: pickle: Add missing NULL check to save_global(). (GH-8851)
b14a68f 
Reported by Svace static analyzer.
(cherry picked from commit f8c06b0)

Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
@izbyshev izbyshev deleted the bpo-34456 branch August 22, 2018 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@izbyshev @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni