Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo with asynccontextmanager #8845

Merged
merged 1 commit into from
Aug 25, 2018
Merged

Fixed typo with asynccontextmanager #8845

merged 1 commit into from
Aug 25, 2018

Conversation

alvassin
Copy link
Contributor

Fixed confusing typo.

@alvassin alvassin requested a review from 1st1 as a code owner August 21, 2018 08:57
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Aug 21, 2018
@alvassin
Copy link
Contributor Author

CLA signed.

@Mariatta Mariatta merged commit 416cbce into python:master Aug 25, 2018
@miss-islington
Copy link
Contributor

Thanks @alvassin for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 25, 2018
@alvassin @miss-islington
Fixed typo with asynccontextmanager code example (pythonGH-8845)
4016be7 
`yield conn`, instead of just `yield`.
(cherry picked from commit 416cbce)

Co-authored-by: Alexander Vasin <hi@alvass.in>
@bedevere-bot
Copy link

GH-8917 is a backport of this pull request to the 3.7 branch.

@Mariatta
Copy link
Member

Thanks @alvassin and congrats on your first contribution to CPython 🌮

miss-islington added a commit that referenced this pull request Aug 25, 2018
@miss-islington @alvassin
Fixed typo with asynccontextmanager code example (GH-8845)
1f9621c 
`yield conn`, instead of just `yield`.
(cherry picked from commit 416cbce)

Co-authored-by: Alexander Vasin <hi@alvass.in>
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Aug 27, 2018
@CuriousLearner
Merge branch 'master' into fix-issue24255
c50bb33 
* master: (104 commits)
  Fast path for exact floats in math.hypot() and math.dist() (pythonGH-8949)
  Remove AIX workaround test_subprocess (pythonGH-8939)
  bpo-34503: Fix refleak in PyErr_SetObject() (pythonGH-8934)
  closes bpo-34504: Remove the useless NULL check in PySequence_Check(). (pythonGH-8935)
  closes bpo-34501: PyType_FromSpecWithBases: Check spec->name before dereferencing it. (pythonGH-8930)
  closes bpo-34502: Remove a note about utf8_mode from sys.exit() docs. (pythonGH-8928)
  Remove unneeded PyErr_Clear() in _winapi_SetNamedPipeHandleState_impl() (pythonGH-8281)
  Fix markup in stdtypes documentation (pythonGH-8905)
  bpo-34395: Don't free allocated memory on realloc fail in load_mark() in _pickle.c. (pythonGH-8788)
  Fix upsizing of marks stack in pickle module. (pythonGH-8860)
  bpo-34171: Prevent creating Lib/trace.cover when run the trace module. (pythonGH-8841)
  closes bpo-34493: Objects/genobject.c: Add missing NULL check to compute_cr_origin() (pythonGH-8911)
  Fixed typo with asynccontextmanager code example (pythonGH-8845)
  bpo-34426: fix typo (__lltrace__ -> __ltrace__) (pythonGH-8822)
  bpo-13312: Avoid int underflow in time year. (pythonGH-8912)
  bpo-34492: Python/coreconfig.c: Fix _Py_wstrlist_copy() (pythonGH-8910)
  bpo-34448: Improve output of usable wchar_t check (pythonGH-8846)
  closes bpo-34471: _datetime: Add missing NULL check to tzinfo_from_isoformat_results. (pythonGH-8869)
  bpo-6700: Fix inspect.getsourcelines for module level frames/tracebacks (pythonGH-8864)
  Fix typo in the dataclasses's doc (pythonGH-8896)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@Mariatta Mariatta Mariatta approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alvassin @the-knights-who-say-ni @miss-islington @bedevere-bot @Mariatta @asottile @serhiy-storchaka