bpo-34436: Fix check that disables overallocation for the last fmt sp… #8826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecifier Reported by Svace static analyzer.
serhiy-storchaka
approved these changes
Aug 20, 2018
vstinner
reviewed
Aug 20, 2018
Objects/bytesobject.c
Outdated
| @@ -819,7 +819,7 @@ _PyBytes_FormatEx(const char *format, Py_ssize_t format_len, | |||
| if (v == NULL) | |||
| goto error; | |||
|
|
|||
| if (fmtcnt < 0) { | |||
| if (fmtcnt == 0) { | |||
| /* last writer: disable writer overallocation */ | |||
There was a problem hiding this comment.
There is a typo in the original code: it should be "last write". Would you mind to fix it as well?
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 23, 2018
…ecifier (pythonGH-8826) Reported by Svace static analyzer. (cherry picked from commit ccd9975) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
|
GH-8865 is a backport of this pull request to the 3.7 branch. |
|
GH-8866 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 23, 2018
…ecifier (pythonGH-8826) Reported by Svace static analyzer. (cherry picked from commit ccd9975) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ecifier
Reported by Svace static analyzer.
https://bugs.python.org/issue34436