Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34435: Add missing NULL check to unicode_encode_ucs1() #8823

Merged
merged 1 commit into from
Aug 19, 2018
Merged

bpo-34435: Add missing NULL check to unicode_encode_ucs1() #8823

merged 1 commit into from
Aug 19, 2018

Conversation

izbyshev
Copy link
Contributor

@izbyshev izbyshev commented Aug 19, 2018 •
edited by bedevere-bot
Loading

Reported by Svace static analyzer.

https://bugs.python.org/issue34435

@serhiy-storchaka serhiy-storchaka merged commit 74a307d into python:master Aug 19, 2018
@miss-islington
Copy link
Contributor

Thanks @izbyshev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 19, 2018
@izbyshev @miss-islington
bpo-34435: Add missing NULL check to unicode_encode_ucs1(). (pythonGH…
da8a9d6 
…-8823)

Reported by Svace static analyzer.
(cherry picked from commit 74a307d)

Co-authored-by: Alexey Izbyshev <izbyshev@users.noreply.github.com>
@bedevere-bot
Copy link

GH-8824 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-8825 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 19, 2018
@izbyshev @miss-islington
bpo-34435: Add missing NULL check to unicode_encode_ucs1(). (pythonGH…
b91a36a 
…-8823)

Reported by Svace static analyzer.
(cherry picked from commit 74a307d)

Co-authored-by: Alexey Izbyshev <izbyshev@users.noreply.github.com>
@izbyshev izbyshev deleted the bpo-34435 branch August 19, 2018 19:09
miss-islington added a commit that referenced this pull request Aug 19, 2018
@miss-islington @izbyshev
bpo-34435: Add missing NULL check to unicode_encode_ucs1(). (GH-8823)
1e596d3 
Reported by Svace static analyzer.
(cherry picked from commit 74a307d)

Co-authored-by: Alexey Izbyshev <izbyshev@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Aug 19, 2018
@miss-islington @izbyshev
bpo-34435: Add missing NULL check to unicode_encode_ucs1(). (GH-8823)
e77cdae 
Reported by Svace static analyzer.
(cherry picked from commit 74a307d)

Co-authored-by: Alexey Izbyshev <izbyshev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@izbyshev @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni