Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34397: Remove redundant overflow checks in list and tuple implementation. #8757

Merged
merged 1 commit into from
May 25, 2020
Merged

bpo-34397: Remove redundant overflow checks in list and tuple implementation. #8757

merged 1 commit into from
May 25, 2020

Conversation

sir-sigurd
Copy link
Contributor

@sir-sigurd sir-sigurd commented Aug 13, 2018 •
edited by bedevere-bot
Loading

@csabella csabella requested review from vadmium and pitrou May 19, 2019 01:04
jdemeyer
jdemeyer requested changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@jdemeyer jdemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the comments of Tim Peters on https://bugs.python.org/issue34397: the assertions should check what is actually required.

@sir-sigurd sir-sigurd force-pushed the list-tuple-overlow-checks branch from b96b7db to 4b5bbd8 Compare August 10, 2019 15:10
@sir-sigurd
Copy link
Contributor Author

I reworked assertions as requested.

@sir-sigurd
Copy link
Contributor Author

@tim-one
Does it look OK now?

@csabella csabella requested a review from tim-one February 6, 2020 02:27
tim-one
tim-one approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@tim-one tim-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough! Thank you 😃.

@csabella
Copy link
Contributor

Merging based on @tim-one's approval.

@miss-islington miss-islington merged commit e682b26 into python:master May 25, 2020
@sir-sigurd sir-sigurd deleted the list-tuple-overlow-checks branch May 25, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdemeyer jdemeyer jdemeyer requested changes

@tim-one tim-one tim-one approved these changes

@vadmium vadmium Awaiting requested review from vadmium

@pitrou pitrou Awaiting requested review from pitrou

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sir-sigurd @csabella @jdemeyer @tim-one @the-knights-who-say-ni @bedevere-bot @miss-islington