Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34212: modules that are built as part of the core library should be built with at least -DPy_BUILD_CORE_BUILTIN defined #8712

Merged
merged 1 commit into from
Nov 27, 2018
Merged

bpo-34212: modules that are built as part of the core library should be built with at least -DPy_BUILD_CORE_BUILTIN defined #8712

merged 1 commit into from
Nov 27, 2018

Conversation

embray
Copy link
Contributor

@embray embray commented Aug 9, 2018 •
edited by bedevere-bot
Loading

This is a cleaner alternative to #8446.

https://bugs.python.org/issue34212

@embray
bpo-34212: modules that are build as part of the core library should …
3551c7e 
…be built with at least -DPy_BUILD_CORE_BUILTIN defined
This was referenced Aug 9, 2018
Closed
Closed
@gvanrossum gvanrossum changed the title bpo-34212: modules built as part of the core library should use bpo-34212: modules that are build as part of the core library should be built with at least -DPy_BUILD_CORE_BUILTIN defined bpo-34212: modules that are build as part of the core library should be built with at least -DPy_BUILD_CORE_BUILTIN defined Nov 26, 2018
@benjaminp benjaminp merged commit da324d5 into python:master Nov 27, 2018
@miss-islington
Copy link
Contributor

Thanks @embray for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 27, 2018
@embray @miss-islington
closes bpo-34212: Build core extension modules with Py_BUILD_CORE_BUI…
4ced3e1 
…LTIN. (pythonGH-8712)

(cherry picked from commit da324d5)

Co-authored-by: E. M. Bray <erik.m.bray@gmail.com>
@bedevere-bot
Copy link

GH-10734 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Nov 27, 2018
@miss-islington @embray
closes bpo-34212: Build core extension modules with Py_BUILD_CORE_BUI…
716a808 
…LTIN. (GH-8712)

(cherry picked from commit da324d5)

Co-authored-by: E. M. Bray <erik.m.bray@gmail.com>
@embray
Copy link
Contributor Author

embray commented Nov 27, 2018

@benjaminp Thank you!

@embray embray deleted the bpo-34212-2 branch November 27, 2018 15:20
@embray embray changed the title bpo-34212: modules that are build as part of the core library should be built with at least -DPy_BUILD_CORE_BUILTIN defined bpo-34212: modules that are built as part of the core library should be built with at least -DPy_BUILD_CORE_BUILTIN defined Nov 27, 2018
@embray embray mentioned this pull request Feb 26, 2019
Merged
4 tasks
@vinklein vinklein mannequin mentioned this pull request Feb 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@embray @miss-islington @bedevere-bot @benjaminp @the-knights-who-say-ni