Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34047: IDLE: fix mousewheel scrolling direction on macOS #8678

Merged
merged 3 commits into from
Aug 10, 2018
Merged

bpo-34047: IDLE: fix mousewheel scrolling direction on macOS #8678

merged 3 commits into from
Aug 10, 2018

Conversation

taleinat
Copy link
Contributor

@taleinat taleinat commented Aug 5, 2018 •
edited by bedevere-bot
Loading

Thanks to Vlad Tudorache for discovering the cause of the bug!

https://bugs.python.org/issue34047

@taleinat taleinat requested a review from terryjreedy August 5, 2018 12:48
@terryjreedy terryjreedy added type-bug An unexpected behavior, bug, or error needs backport to 3.6 labels Aug 5, 2018
terryjreedy
terryjreedy requested changes Aug 6, 2018
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As explained on the issue, the correction exposed more bugs. I am rewriting the function and will improve the doctest.

@python python deleted a comment from bedevere-bot Aug 6, 2018
@terryjreedy
Copy link
Member

Approved pending htest or equivalent passing on Mac by scrolling 'correctly' for Mac.

@taleinat
Copy link
Contributor Author

@terryjreedy, I tested this on my mac, both in IDLE proper and the htest, and all looks working as expected.

I specifically checked that scroll direction is consistent with the rest of the OS with system setting "Scroll direction: Natural" either on or off.

@taleinat taleinat merged commit 077059e into python:master Aug 10, 2018
@miss-islington
Copy link
Contributor

Thanks @taleinat for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-8723 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-8724 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 10, 2018
@taleinat @miss-islington
bpo-34047: IDLE: fix mousewheel scrolling direction on macOS (pythonG…
258d0ac 
…H-8678)

(cherry picked from commit 077059e)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 10, 2018
@taleinat @miss-islington
bpo-34047: IDLE: fix mousewheel scrolling direction on macOS (pythonG…
5f02b29 
…H-8678)

(cherry picked from commit 077059e)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
miss-islington added a commit that referenced this pull request Aug 10, 2018
@miss-islington @taleinat
bpo-34047: IDLE: fix mousewheel scrolling direction on macOS (GH-8678)
ea8835f 
(cherry picked from commit 077059e)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
miss-islington added a commit that referenced this pull request Aug 10, 2018
@miss-islington @taleinat
bpo-34047: IDLE: fix mousewheel scrolling direction on macOS (GH-8678)
ca4badb 
(cherry picked from commit 077059e)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>
@taleinat taleinat deleted the bpo-34047/idle_scroll_direction_macos branch August 12, 2018 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@taleinat @terryjreedy @miss-islington @bedevere-bot @the-knights-who-say-ni