Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34335: Do not mix @asyncio.coroutine decorator and await in asyncio docs #8674

Merged
merged 1 commit into from
Aug 7, 2018
Merged

bpo-34335: Do not mix @asyncio.coroutine decorator and await in asyncio docs #8674

merged 1 commit into from
Aug 7, 2018

Conversation

termim
Copy link
Contributor

@termim termim commented Aug 4, 2018 •
edited by bedevere-bot
Loading

This is a leftover from:
bpo-32258: Replace 'yield from' to 'await' in asyncio docs (#4779)

https://bugs.python.org/issue34335

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Aug 4, 2018
@Mariatta Mariatta merged commit d2ac400 into python:master Aug 7, 2018
@miss-islington
Copy link
Contributor

Thanks @termim for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@Mariatta
Copy link
Member

Mariatta commented Aug 7, 2018

Thanks @termim and congrats on your first contribution to CPython 🌮

@bedevere-bot
Copy link

GH-8704 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 7, 2018
@termim @miss-islington
bpo-34335: Use async/await syntax in documentation examples (pythonGH…
0a97520 
…-8674)

(cherry picked from commit d2ac400)

Co-authored-by: Mikhail Terekhov <termim@gmail.com>
miss-islington added a commit that referenced this pull request Aug 7, 2018
@miss-islington @termim
bpo-34335: Use async/await syntax in documentation examples (GH-8674)
fac4976 
(cherry picked from commit d2ac400)

Co-authored-by: Mikhail Terekhov <termim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

@gpshead gpshead Awaiting requested review from gpshead

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@termim @miss-islington @Mariatta @bedevere-bot @the-knights-who-say-ni