-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grammar of asynchronous iterator glossary entry #8657
Merged
Mariatta
merged 1 commit into
python:master
from
andresdelfino:fix-async-iterator-grammar
Aug 9, 2018
Merged
Fix grammar of asynchronous iterator glossary entry #8657
Mariatta
merged 1 commit into
python:master
from
andresdelfino:fix-async-iterator-grammar
Aug 9, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mariatta
approved these changes
Aug 9, 2018
I think this looks good, but I'll let @python/asyncio team have a quick look before I merge. |
1st1
approved these changes
Aug 9, 2018
LGTM. |
Thanks @andresdelfino for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
Thanks! |
GH-8715 is a backport of this pull request to the 3.7 branch. |
GH-8716 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 9, 2018
(cherry picked from commit cf2c5e8) Co-authored-by: Andrés Delfino <adelfino@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 9, 2018
(cherry picked from commit cf2c5e8) Co-authored-by: Andrés Delfino <adelfino@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Aug 9, 2018
(cherry picked from commit cf2c5e8) Co-authored-by: Andrés Delfino <adelfino@gmail.com>
Mariatta
pushed a commit
that referenced
this pull request
Aug 9, 2018
(cherry picked from commit cf2c5e8) Co-authored-by: Andrés Delfino <adelfino@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.