bpo-34301: Add _PyInterpreterState_Get() helper function #8592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sys_setcheckinterval() now uses a local variable to parse arguments, before writing into interp->check_interval.
vstinner
commented
Aug 1, 2018
Python/ceval.c
Outdated
| @@ -532,8 +532,8 @@ PyEval_EvalFrame(PyFrameObject *f) { | |||
| PyObject * | |||
| PyEval_EvalFrameEx(PyFrameObject *f, int throwflag) | |||
| { | |||
| PyThreadState *tstate = PyThreadState_GET(); | |||
| return tstate->interp->eval_frame(f, throwflag); | |||
| PyInterpreterState *interp = _PyInterpreterState_Get(); | |||
There was a problem hiding this comment.
Hum, PyThreadState_GET() doesn't check if the result is NULL, whereas _PyInterpreterState_Get() does. Do we need a _PyInterpreterState_GetUnchecked() for performance critical code?
|
I tried to declare _PyInterpreterState_Get() only if Py_BUILD_CORE is defined, but I also want to use it in Programs/_testembed.c which isn't compiled with Py_BUILD_CORE. So I only excluded the function from the stable ABI. But maybe we can even add the function to the regular API? |
|
On Windows, the C compiler emits a warning in _PyInterpreter_Get() because the compiler doesn't understand that Py_FatalError() never returns. I proposed the PR #8606 to fix this issue. |
_PyInterpreterState_Get() now fails with a fatal error if tstate->interp is NULL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sys_setcheckinterval() now uses a local variable to parse arguments,
before writing into interp->check_interval.
https://bugs.python.org/issue34301