bpo-31658: Make xml.sax.parse accepting Path objects #8564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoboTiG
force-pushed
the
fix-issue-31658
branch
3 times, most recently
from
96f896f to
8dd5dbc
Compare
merwok
reviewed
Dec 20, 2018
BoboTiG
force-pushed
the
fix-issue-31658
branch
from
8dd5dbc to
04498f8
Compare
merwok
reviewed
Jan 2, 2019
|
@merwok do you think we can move on? |
tirkarthi
reviewed
Jan 8, 2019
Misc/NEWS.d/next/Library/2018-07-30-12-00-15.bpo-31658._bx7a_.rst
Outdated
Show resolved
Hide resolved
|
What is the status? Do you think it needs more work? |
|
Code looks good to me, but I’m a little too busy to merge PRs, watch buildbots, etc. |
|
Thanks again for the patch and thanks @scoder for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue31658