bpo-34267: Update find_python.bat to use 3.7 if available #8552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segevfiner
reviewed
Jul 29, 2018
PCbuild/find_python.bat
Outdated
| @@ -34,7 +34,10 @@ | |||
| @if NOT "%HOST_PYTHON%"=="" @%HOST_PYTHON% -Ec "import sys; assert sys.version_info[:2] >= (3, 6)" >nul 2>nul && (set PYTHON="%HOST_PYTHON%") && (set _Py_Python_Source=found as HOST_PYTHON) && goto :found | |||
|
|
|||
| @rem If py.exe finds a recent enough version, use that one | |||
| @py -3.6 -EV >nul 2>&1 && (set PYTHON=py -3.6) && (set _Py_Python_Source=found with py.exe) && goto :found | |||
| @py -3.7 -EV >nul 2>&1 && (set PYTHON=py -3.7) && (set _Py_Python_Source=found 3.7 with py.exe) && goto :found | |||
There was a problem hiding this comment.
How about:
for %%i in (3.7 3.6) do (
@py -%%i -EV >nul 2>&1 && (set PYTHON=py -%%i) && (set _Py_Python_Source=found %%i with py.exe) && goto :found
)
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 17, 2018
) (cherry picked from commit 6750922) Co-authored-by: Steve Dower <steve.dower@microsoft.com>
|
GH-9373 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34267