Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove creation of a list for row_cast_map in pysqlite_cursor_init(). #8494

Merged
merged 3 commits into from
Jul 30, 2018

Conversation

sir-sigurd
Copy link
Contributor

This list is never used: if detect_types is on, this list will be replaced with another one before row_cast_map is used, if detect_types is off, row_cast_map is not used at all.

This list is never used: if detect_types is on, this list will be
replaced with another one before row_cast_map is used, if
detect_types is off, row_cast_map is not used at all.
@zooba
Copy link
Member

zooba commented Jul 29, 2018

I trust your analysis, but I don't trust my own checking of your analysis :) Could you add a null check at line 252?

if (self->connection->detect_types && self->row_cast_map) {

(Or alternatively, add an assertion inside the block)

@berkerpeksag berkerpeksag merged commit b229b07 into python:master Jul 30, 2018
@sir-sigurd sir-sigurd deleted the sqlite-row_cast_map-init branch July 31, 2018 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants