Skip to content

bpo-29912: Remove overlapping tests in list_tests and seq_tests #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2017
Merged

bpo-29912: Remove overlapping tests in list_tests and seq_tests #847

merged 1 commit into from
Mar 27, 2017

Conversation

DimitrisJim
Copy link
Contributor

@DimitrisJim DimitrisJim commented Mar 27, 2017 •
edited
Loading

Specifically:

  • test_count in list_tests completely duplicates test_count in seq_tests
  • test_index mostly duplicates test_index in seq_tests, removed the duplicated tests and added a super call.
  • test_imul changed similarly to test_index.

@mention-bot
Copy link

@DimitrisJim, thanks for your PR! By analyzing the history of the files in this pull request, we identified @doerwalter, @rhettinger and @birkenfeld to be potential reviewers.

@brettcannon brettcannon added the tests Tests in the Lib/test dir label Mar 27, 2017
@brettcannon
Copy link
Member

For easy reviewing, seq_tests for test_imul and test_index.

@brettcannon brettcannon merged commit d702c50 into python:master Mar 27, 2017
@brettcannon
Copy link
Member

Thanks!

@DimitrisJim DimitrisJim deleted the issue29912 branch March 27, 2017 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DimitrisJim @mention-bot @brettcannon @the-knights-who-say-ni