bpo-34197: Make _csv.Dialect attributes booleans. #8440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attributes skipinitialspace, doublequote and strict are now booleans instead of integers 0 or 1.
methane
reviewed
Jul 25, 2018
| @@ -12,6 +12,7 @@ module instead. | |||
|
|
|||
| #include "Python.h" | |||
| #include "structmember.h" | |||
| #include <stdbool.h> | |||
There was a problem hiding this comment.
http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/stdbool.h.html
How about using bool instead of char? Isn't it portable?
There was a problem hiding this comment.
T_BOOL requires char. I have doubts that _Bool has always the same size and alignment as char.
methane
approved these changes
Jul 25, 2018
| @@ -12,6 +12,7 @@ module instead. | |||
|
|
|||
| #include "Python.h" | |||
| #include "structmember.h" | |||
| #include <stdbool.h> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes skipinitialspace, doublequote and strict are now
booleans instead of integers 0 or 1.
https://bugs.python.org/issue34197