bpo-22689: Copy the result of getenv() in sys_breakpointhook(). #8194
Conversation
serhiy-storchaka
added
type-bug
|
The failure on VSTS: Linux-PR-Coverage seems is not related. |
Python/sysmodule.c
Outdated
| @@ -116,6 +116,11 @@ sys_breakpointhook(PyObject *self, PyObject *const *args, Py_ssize_t nargs, PyOb | |||
| /* The breakpoint is explicitly no-op'd. */ | |||
| Py_RETURN_NONE; | |||
| } | |||
| envar = _PyMem_RawStrdup(envar); | |||
There was a problem hiding this comment.
Gosh, I'm really becoming uncomfortable with all the undocumented, internal, underscored functions. It makes it much harder to understand CPython's implementation since now I have to go read the source for _PyMem_RawStrdup. This isn't the only case of it, and I know we can't fix that in this PR, but I do think we need to do better to document the private C API.
I would suggest adding a comment above this explaining the POSIX semantics, so that a future reader will understand why a copy is being made.
Python/sysmodule.c
Outdated
| @@ -145,11 +152,13 @@ sys_breakpointhook(PyObject *self, PyObject *const *args, Py_ssize_t nargs, PyOb | |||
| Py_DECREF(fromlist); | |||
|
|
|||
| if (module == NULL) { | |||
| PyMem_RawFree(envar); | |||
There was a problem hiding this comment.
This can break error reporting because of this code in the error: section:
int status = PyErr_WarnFormat(
PyExc_RuntimeWarning, 0,
"Ignoring unimportable $PYTHONBREAKPOINT: \"%s\"", envar);
|
When you're done making the requested changes, leave the comment: |
serhiy-storchaka
force-pushed
the
breakpointhook-getenv
branch
from
d267adb to
f775af3
Compare
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-8206 is a backport of this pull request to the 3.7 branch. |
…onGH-8194) (cherry picked from commit f60bf0e) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
Thank you for your review @warsaw! |
) (cherry picked from commit f60bf0e) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
https://bugs.python.org/issue22689