Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34018: Doc'd that type names of SQLite converters are case-insensitive. #8042

Merged
merged 1 commit into from
Jul 3, 2018
Merged

bpo-34018: Doc'd that type names of SQLite converters are case-insensitive. #8042

merged 1 commit into from
Jul 3, 2018

Conversation

sir-sigurd
Copy link
Contributor

@sir-sigurd sir-sigurd commented Jul 2, 2018 •
edited by bedevere-bot
Loading

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

taleinat
taleinat requested changes Jul 3, 2018
View reviewed changes
Doc/library/sqlite3.rst
function for how the type detection works. Note that the case of *typename* and
the name of the type in your query must match!
function for how the type detection works. Note that *typename* and the name of
the type in your query are matched in case-insensitive manner.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please retain the "must match" wording, e.g.: "... must match (case-insensitively)!"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO "must match" wording was about their case and that they "must match" is already contained in The callable will be invoked for all database values that are of the type *typename*., so we need only to state that these types are compared in case-insensitive manner.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon re-reading, you're right!

@taleinat taleinat merged commit 831c297 into python:master Jul 3, 2018
@miss-islington
Copy link
Contributor

Thanks @sir-sigurd for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2018
@sir-sigurd @miss-islington
bpo-34018: Doc'd that type names of SQLite converters are case-insens…
583235a 
…itive. (pythonGH-8042)

(cherry picked from commit 831c297)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
@bedevere-bot
Copy link

GH-8065 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-8066 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2018
@sir-sigurd @miss-islington
bpo-34018: Doc'd that type names of SQLite converters are case-insens…
e484092 
…itive. (pythonGH-8042)

(cherry picked from commit 831c297)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2018
@sir-sigurd @miss-islington
bpo-34018: Doc'd that type names of SQLite converters are case-insens…
ba92128 
…itive. (pythonGH-8042)

(cherry picked from commit 831c297)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
@bedevere-bot
Copy link

GH-8067 is a backport of this pull request to the 3.6 branch.

@sir-sigurd sir-sigurd deleted the sqlite-converter-case branch July 3, 2018 12:03
@taleinat taleinat added the docs Documentation in the Doc dir label Jul 3, 2018
taleinat pushed a commit that referenced this pull request Jul 3, 2018
@miss-islington @sir-sigurd @taleinat
bpo-34018: Doc'd that type names of SQLite converters are case-insens…
6699386 
…itive. (GH-8042) (GH-8065)

(cherry picked from commit 831c297)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
taleinat pushed a commit that referenced this pull request Jul 3, 2018
@miss-islington @sir-sigurd @taleinat
bpo-34018: Doc'd that type names of SQLite converters are case-insens…
f55a818 
…itive. (GH-8042) (GH-8067)

(cherry picked from commit 831c297)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
taleinat pushed a commit that referenced this pull request Jul 3, 2018
@miss-islington @sir-sigurd @taleinat
bpo-34018: Doc'd that type names of SQLite converters are case-insens…
292ce15 
…itive. (GH-8042) (GH-8066)

(cherry picked from commit 831c297)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taleinat taleinat taleinat approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sir-sigurd @bedevere-bot @miss-islington @taleinat @the-knights-who-say-ni