Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bin() and hash() padding in Built-in Functions #7998

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Fix bin() and hash() padding in Built-in Functions #7998

merged 1 commit into from
Jun 29, 2018

Conversation

andresdelfino
Copy link
Contributor

No description provided.

@serhiy-storchaka serhiy-storchaka merged commit bda9c3e into python:master Jun 29, 2018
@miss-islington
Copy link
Contributor

Thanks @andresdelfino for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-8005 is a backport of this pull request to the 3.7 branch.

@serhiy-storchaka
Copy link
Member

Good catch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 29, 2018
@andresdelfino @miss-islington
Fix the indentation in the documentation of bin() and hash() (pythonG…
be4f39c 
…H-7998)

(cherry picked from commit bda9c3e)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

GH-8006 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 29, 2018
@andresdelfino @miss-islington
Fix the indentation in the documentation of bin() and hash() (pythonG…
0f192f4 
…H-7998)

(cherry picked from commit bda9c3e)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@miss-islington
Copy link
Contributor

Sorry, @andresdelfino and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker bda9c3eae3ad16e43145599ac6359bfdcaf1fd4a 2.7

@andresdelfino andresdelfino deleted the fix-bin-hex-padding branch June 29, 2018 10:03
@andresdelfino
Copy link
Contributor Author

Serhiy, this isn't needed for 2.7. No issue there.

miss-islington added a commit that referenced this pull request Jun 29, 2018
@miss-islington @andresdelfino
Fix the indentation in the documentation of bin() and hash() (GH-7998)
d0b4428 
(cherry picked from commit bda9c3e)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
miss-islington added a commit that referenced this pull request Jun 29, 2018
@miss-islington @andresdelfino
Fix the indentation in the documentation of bin() and hash() (GH-7998)
a730279 
(cherry picked from commit bda9c3e)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@serhiy-storchaka
Copy link
Member

Thanks @andresdelfino.

@serhiy-storchaka serhiy-storchaka removed their assignment Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andresdelfino @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni