Skip to content

bpo-27500: Fix sttaic ver of getaddrinfo to resolve IPv6 addresses #7993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 29, 2018
Merged

bpo-27500: Fix sttaic ver of getaddrinfo to resolve IPv6 addresses #7993

merged 4 commits into from
Jun 29, 2018

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Jun 28, 2018 •
edited by bedevere-bot
Loading

@1st1 1st1 requested a review from asvetlov as a code owner June 28, 2018 17:01
@1st1 1st1 closed this Jun 28, 2018
@1st1 1st1 reopened this Jun 28, 2018
vstinner
vstinner approved these changes Jun 28, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Be carefully of the typo in the commit message: "bpo-27500: Fix sttaic ver of getaddrinfo..."

Lib/test/test_asyncio/test_base_events.py
@@ -1077,6 +1077,26 @@ def test_create_server_stream_bittype(self):
srv.close()
self.loop.run_until_complete(srv.wait_closed())

@unittest.skipUnless(hasattr(socket, 'AF_INET6'), 'no IPv6 support')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might use support.IPV6_ENABLED

@1st1 1st1 merged commit d904c23 into python:master Jun 29, 2018
@miss-islington
Copy link
Contributor

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@1st1 1st1 deleted the fixaf6 branch June 29, 2018 01:59
@bedevere-bot
Copy link

GH-8000 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 29, 2018
@1st1 @miss-islington
bpo-27500: Fix static version of getaddrinfo to resolve IPv6 (pythonG…
adde85f 
…H-7993)

(cherry picked from commit d904c23)

Co-authored-by: Yury Selivanov <yury@magic.io>
@bedevere-bot
Copy link

GH-8001 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 29, 2018
@1st1 @miss-islington
bpo-27500: Fix static version of getaddrinfo to resolve IPv6 (pythonG…
36223f2 
…H-7993)

(cherry picked from commit d904c23)

Co-authored-by: Yury Selivanov <yury@magic.io>
@1st1
Copy link
Member Author

1st1 commented Jun 29, 2018

Thanks for a review, Victor!

miss-islington added a commit that referenced this pull request Jun 29, 2018
@miss-islington @1st1
bpo-27500: Fix static version of getaddrinfo to resolve IPv6 (GH-7993)
3ed4414 
(cherry picked from commit d904c23)

Co-authored-by: Yury Selivanov <yury@magic.io>
miss-islington added a commit that referenced this pull request Jun 29, 2018
@miss-islington @1st1
bpo-27500: Fix static version of getaddrinfo to resolve IPv6 (GH-7993)
c00144c 
(cherry picked from commit d904c23)

Co-authored-by: Yury Selivanov <yury@magic.io>
asvetlov
asvetlov reviewed Jun 29, 2018
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm late but lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov left review comments

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@1st1 @miss-islington @bedevere-bot @vstinner @asvetlov @the-knights-who-say-ni