Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-25007: Add copy protocol support to zlib compressors and decompressors #7940

Merged

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Jun 26, 2018

This PR was created from scratch; the patch submitted on the bug tracker two years ago needed to be rewritten, and it lacked deepcopy() support, documentation, and tests.

https://bugs.python.org/issue25007

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just two style nits.

@@ -231,6 +231,11 @@ Compression objects support the following methods:
compress a set of data that share a common initial prefix.


.. versionchanged:: 3.8
Added :func:`copy.copy` and :func:`copy.deepcopy` support to Compression
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use lower case for compression objects.

@@ -298,6 +303,11 @@ Decompression objects support the following methods and attributes:
seeks into the stream at a future point.


.. versionchanged:: 3.8
Added :func:`copy.copy` and :func:`copy.deepcopy` support to Decompression
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Jun 27, 2018
@serhiy-storchaka serhiy-storchaka merged commit d2cbfff into python:master Jun 27, 2018
@ZackerySpytz ZackerySpytz deleted the bpo-25007-zlib-comp-decomp-copy branch June 30, 2018 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants