bpo-33671: Replace platform test for darwin with support.MACOS

[4383]

Summary

Replace all platform test on darwin system with support.MACOS introduced by #7800

This pull request is focused on darwin, win will be replaced in another pull request.

https://bugs.python.org/issue33671

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again for your contribution, we look forward to reviewing it!

[4383]

Signed CLA :)

[pablogsal]

The tests are failing because MACOS is not imported (You need to use `support.MACOS).

[pablogsal]

Hi @4383 and thank you for your contribution!

The CI is failing right now with this error:

ERROR: test_path_objects (test.test_logging.HandlerTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/python/cpython/Lib/test/test_logging.py", line 616, in test_path_objects
    if MACOS or sys.platform == 'linux':
NameError: name 'MACOS' is not defined

Notice that to avoid waiting for the CI to fail in the PR you can run your tests locally. For example:

./configure --with-pydebug && make && make test

[ned-deily]

Thanks for the contribution. But I think this or any similar changes should not be merged until we've further discussed the implications of #7800 itself.

[4383]

Hi @ned-deily, no problems, I can maintain these changes up-to-date during the time you need to measure implications of #7800 :)

Hi @pablogsal, thanks for your help, I pushed too hastily. Errors fixed :)

[ned-deily]

It was decided to revert the changes in #7800 so this suggested PR no longer applies. Thanks again for your contribution, @4383