Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33912: Add missing warning filter to test_exec_filename() #7839

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

chrisfrederickson
Copy link
Contributor

@chrisfrederickson chrisfrederickson commented Jun 21, 2018

Added the missing warning filter to test_exec_filename() as mentioned in this issue: https://bugs.python.org/issue33912

First pull request here so let me know if there are any issues (signed the CLA, but it has not been processed yet).

https://bugs.python.org/issue33912

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again for your contribution, we look forward to reviewing it!

Copy link
Contributor

@takluyver takluyver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think this doesn't need a NEWS entry because it's a fix to an unreleased change. I don't know if there's a way to tell the bot that's checking for that that it's not necessary.

@vstinner
Copy link
Member

Hi @chrisfrederickson, thank you for your contribution! Did you sign the Python CLA as the Knight told you?
#7839 (comment)

@chrisfrederickson
Copy link
Contributor Author

@vstinner Yep! And it looks like it has been processed now as the "Contributor Form Received" field says Yes on bus.python.org.

@vstinner
Copy link
Member

I ran manually: "./python -W error -m test -v test_warnings" fails without the PR, and pass with this PR.

@vstinner vstinner merged commit 419e88d into python:master Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants